Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: objectPageHeader styling and modules card #3487

Merged
merged 2 commits into from
Nov 20, 2024
Merged

fix: objectPageHeader styling and modules card #3487

merged 2 commits into from
Nov 20, 2024

Conversation

mrCherry97
Copy link
Contributor

Description

Changes proposed in this pull request:

  • fix: objectPageHeader styling and modules card

Related issue(s)

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 19, 2024
@mrCherry97 mrCherry97 marked this pull request as ready for review November 19, 2024 09:29
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Nov 19, 2024
@mrCherry97 mrCherry97 mentioned this pull request Nov 19, 2024
Open
@akucharska akucharska self-assigned this Nov 20, 2024
akucharska
akucharska requested changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@akucharska akucharska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be this white background under the cards?
Screenshot 2024-11-20 at 08 33 56

@kyma-bot kyma-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 20, 2024
@mrCherry97
Copy link
Contributor Author

After rebase with feature branch, everything is working correctly
image

@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 20, 2024
@mrCherry97 mrCherry97 merged commit 5e543ee into kyma-project:ui5-migrate-v2 Nov 20, 2024
6 of 13 checks passed
@mrCherry97 mrCherry97 deleted the fix-modules-styles branch November 20, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akucharska akucharska akucharska approved these changes

@dbadura dbadura Awaiting requested review from dbadura dbadura is a code owner

@chriskari chriskari Awaiting requested review from chriskari chriskari is a code owner

@OliwiaGowor OliwiaGowor Awaiting requested review from OliwiaGowor OliwiaGowor is a code owner

Assignees

@akucharska akucharska

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrCherry97 @akucharska @kyma-bot