Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: defaultProps #3469

Merged
merged 2 commits into from
Nov 13, 2024
Merged

fix: defaultProps #3469

merged 2 commits into from
Nov 13, 2024

Conversation

mrCherry97
Copy link
Contributor

Description

Changes proposed in this pull request:

  • remove defaultProps from all of the app
  • move this defaultProps to newer prop = defaultValue
  • remove disableEdit prop from ResourcesList - it's no longer valid

Related issue(s)

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 12, 2024
@mrCherry97 mrCherry97 marked this pull request as ready for review November 12, 2024 10:06
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Nov 12, 2024
@OliwiaGowor OliwiaGowor self-assigned this Nov 12, 2024
@mrCherry97 mrCherry97 mentioned this pull request Nov 12, 2024
Open
@mrCherry97 mrCherry97 merged commit a565ab1 into kyma-project:ui5-migrate-v2 Nov 13, 2024
4 of 12 checks passed
@mrCherry97 mrCherry97 deleted the fix-defaultProps branch November 13, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OliwiaGowor OliwiaGowor OliwiaGowor left review comments

@akucharska akucharska Awaiting requested review from akucharska akucharska is a code owner

@dbadura dbadura Awaiting requested review from dbadura dbadura is a code owner

@chriskari chriskari Awaiting requested review from chriskari chriskari is a code owner

Assignees

@OliwiaGowor OliwiaGowor

Labels
cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrCherry97 @OliwiaGowor @kyma-bot