Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download button - in preferences for downloading policies #2546

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Download button - in preferences for downloading policies #2546

wants to merge 5 commits into from

Conversation

Akatuoro
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Add download button in user preferences for downloading policies
    • Enabled policies and rules are downloaded in datree's Custom Rules format, so that they can either be re-uploaded in busola on another cluster or be used for validation using the datree cli
  • Add support for datree's Custom Rules format when loading rule sets
  • Fix duplicate enum values in Pod Security Standard rules

Related issue(s)

Enhancement for #2376

@kyma-bot
Copy link
Contributor

Hi @Akatuoro. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 11, 2023
IwonaLanger
IwonaLanger reviewed Aug 21, 2023
View reviewed changes
docs/resource-validation/README.md
@@ -56,6 +56,43 @@ Policies can also reference rules in different rule sets as long as they are loa

To see the full specifications, check the [example rule-set](../../examples/resource-validation/rule-set.yaml).

### Alternative format: Custom Rules

Rules and policies can also be given using [datree's Custom Rules](https://hub.datree.io/custom-rules/custom-rules-overview) format as part of a rule set.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link doesn't work (returns 404).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IwonaLanger, thanks for checking this. I also did a check last week and can confirm that the page was indeed a 404 page temporarily. Now it is up again...

As it is an external link, this is not under our control. Should we keep it like it is? Alternatively, we could remove the link completely or only link to the entry page hub.datree.io. But I think a deep link would be more helpful.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Akatuoro Let's keep the link. If it was just a temporary failure, there's no need to remove it.

@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 29, 2023
@halamix2
Copy link
Member

halamix2 commented Oct 3, 2023

/retest

@kyma-bot
Copy link
Contributor

kyma-bot commented Oct 3, 2023 •
edited
Loading

@Akatuoro: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-busola-web-deployment-check 8bacf4e link true /test pre-busola-web-deployment-check

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyma-bot
Copy link
Contributor

kyma-bot commented Dec 2, 2023

This issue or PR has been automatically marked as stale due to the lack of recent activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Close this issue or PR with /close

If you think that I work incorrectly, kindly raise an issue with the problem.

/lifecycle stale

@kyma-bot kyma-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 2, 2023
@kyma-bot
Copy link
Contributor

kyma-bot commented Dec 9, 2023

This issue or PR has been automatically closed due to the lack of activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle stale

If you think that I work incorrectly, kindly raise an issue with the problem.

/close

@kyma-bot kyma-bot closed this Dec 9, 2023
@kyma-bot
Copy link
Contributor

kyma-bot commented Dec 9, 2023

@kyma-bot: Closed this PR.

In response to this:

This issue or PR has been automatically closed due to the lack of activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle stale

If you think that I work incorrectly, kindly raise an issue with the problem.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mrCherry97 mrCherry97 reopened this Jan 31, 2024
@mrCherry97 mrCherry97 requested a review from chriskari as a code owner January 31, 2024 12:47
@mrCherry97 mrCherry97 removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 31, 2024
@mrCherry97 mrCherry97 changed the title Download button Download button - in preferences for downloading policies Jan 31, 2024
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IwonaLanger IwonaLanger IwonaLanger approved these changes

@NHingerl NHingerl Awaiting requested review from NHingerl

@grego952 grego952 Awaiting requested review from grego952

@nataliasitko nataliasitko Awaiting requested review from nataliasitko

@mmitoraj mmitoraj Awaiting requested review from mmitoraj

@akucharska akucharska Awaiting requested review from akucharska akucharska is a code owner

@mrCherry97 mrCherry97 Awaiting requested review from mrCherry97 mrCherry97 is a code owner

@valentinvieriu valentinvieriu Awaiting requested review from valentinvieriu

@chriskari chriskari Awaiting requested review from chriskari chriskari is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@IwonaLanger IwonaLanger

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Akatuoro @kyma-bot @halamix2 @IwonaLanger @mrCherry97