Fix rendering issue for multiple APIRules #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
cla: yes
added 8 commits
May 22, 2024 10:05
…ng and less UI logic
kyma-bot
added
size/L
triffer
changed the title
kyma-bot
added
size/M
kolodziejczak
approved these changes
May 24, 2024
nataliasitko
approved these changes
May 24, 2024
nataliasitko
pushed a commit
to nataliasitko/api-gateway
that referenced
this pull request
May 27, 2024
* Fix host link when multiple APIRules exist * Add release notes * Update release notes * Add retries to reduce flakiness of tests * Make tests more reliable by using scrollIntoView * Fix scrolling issue with APIRule name * Make host in APIRules only a text field to have more reliable rendering and less UI logic * Remove unused code --------- Co-authored-by: Marek Kołodziejczak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rendering of the Host link for multiple APIRules fails and doesn't render the APIRule list. Additionally, the filtering of the APIRules for the host link must be moved to the list to be accurate.
Since we support multiple hosts with version v1beta2 and the host link is not working correctly for some time. we should just remove the link and render the value of the host field. In the details we can keep the host link for now.
Changes proposed in this pull request:
Related issues