Add "--verify" option for installations. #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… binary releases from swift.org. Adding local cache urls for the 3.0.1 version.
kylef
reviewed
Dec 10, 2016
| curl -O "$URL" | ||
| curl -O "$URL.sig" | ||
| gpg --verify "swift-$VERSION"*.sig | ||
| tar xzf "swift-$VERSION"*.tar.gz |
There was a problem hiding this comment.
It's just matching the downloaded sig and tar files, the actual file names aren't captured anywhere AFAIK so I base the match on convention. It could probably be simplified since only one of each would be downloaded into that temp dir, at least I think that's how it works.
|
Thanks for the PR, let me test this out soon and I'll get this merged in. Looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #64. The install command now accepts a verify option that will download and check the gpg signature. For security, we do not automatically install any keys during the swift installation step, and instead assume (with documentation) that they have been installed by the user out-of-band.