Get most of the tests to pass #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxrjones
changed the title
Co-authored-by: Davis Bennett <[email protected]>
7 tasks
maxrjones
commented
Dec 15, 2024
| @@ -158,12 +168,13 @@ async def _transform_list_dir( | |||
| # We assume that the underlying object-store implementation correctly handles the | |||
| # prefix, so we don't double-check that the returned results actually start with the | |||
| # given prefix. | |||
| prefix_len = len(prefix) | |||
| prefix_len = len(prefix) + 1 # If one is not added to the length, all items will contain "/" | |||
There was a problem hiding this comment.
Actually, should we test if a user defines prefix as (e.g.,) "foo/" rather than "foo" before automatically adding 1?
There was a problem hiding this comment.
Ideally it shouldn't be necessary to check again in Python
kylebarron
approved these changes
Dec 16, 2024
| @@ -158,12 +168,13 @@ async def _transform_list_dir( | |||
| # We assume that the underlying object-store implementation correctly handles the | |||
| # prefix, so we don't double-check that the returned results actually start with the | |||
| # given prefix. | |||
| prefix_len = len(prefix) | |||
| prefix_len = len(prefix) + 1 # If one is not added to the length, all items will contain "/" | |||
There was a problem hiding this comment.
Ideally it shouldn't be necessary to check again in Python
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes previously failing tests