Update obstore tests #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxrjones
commented
Dec 13, 2024
| super().__init__(read_only=read_only) | ||
|
|
||
| def __str__(self) -> str: | ||
| return f"object://{self.store}" | ||
|
|
||
| def __repr__(self) -> str: | ||
| return f"ObjectStore({self!r})" | ||
| return f"ObjectStore({self})" |
There was a problem hiding this comment.
This was changed to avoid a recursion error when __repr__ is called
Comment on lines
+44
to
+54
| if not isinstance( | ||
| store, | ||
| ( | ||
| obs.store.AzureStore, | ||
| obs.store.GCSStore, | ||
| obs.store.HTTPStore, | ||
| obs.store.S3Store, | ||
| obs.store.LocalStore, | ||
| obs.store.MemoryStore, | ||
| ), | ||
| ): |
There was a problem hiding this comment.
@kylebarron I couldn't find an abstract base class or another way to simplify this, but suggestions for better approaches would be welcome
There was a problem hiding this comment.
Hmm, perhaps we should have a base class.
| @@ -38,18 +38,29 @@ def __eq__(self, value: object) -> bool: | |||
| if not isinstance(value, ObjectStore): | |||
| return False | |||
|
|
|||
| return self.store.__eq__(value.store) | |||
| return bool(self.store.__eq__(value.store)) | |||
There was a problem hiding this comment.
This was added to avoid type errors with mypy
kylebarron
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.