-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icudtl.dat fix #270
Icudtl.dat fix #270
Conversation
Revert "skip test_Paragraph_init0 on windows for now; investigate later" This reverts commit 10bf421.
Revert "skia.Unicodes.ICU.Make() returns "None" on windows. Disabling skia.Unicodes tests on windows for the moment." This reverts commit 01e9fc5.
This reverts commit 39b6e0d.
…E_TEST was misleading
The CI error is
It is either all the quotes and double quotes, or the length. Probably need to put it in a shell script. |
Okay, venv is significantly different from just plain running "import skia; ...". And it is failing on something that used to pass:
|
Filed the shaper failure upstream: https://issues.skia.org/371224771 |
Started a discussion over at rust-skia rust-skia/rust-skia#1041 |
…ng icudtl.dat+MakeFromShapedText failure Conflicts: tests/test_font.py
So the presence of the file on windows breaks shaping. If it is absent, you get a warning (and likely something else does not work) |
use
to get python path? |
Superceded by #279 |
Download icudtl.dat in CI, re-enable tests and update README.m130.
Fixes #268