-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: ganache => hardhat #630
Conversation
Changing to draft since this one is proving painful to fully resolve until there is resolution to NomicFoundation/edr#360, such as NomicFoundation/hardhat#4718. In short, hardhat does not recognize EDIT: They've resolved the issue in the latest release: https://github.com/NomicFoundation/hardhat/releases/tag/hardhat%402.22.5 |
fa9b2ec
to
f59830b
Compare
This is finally unblocked. I think we can go ahead with dropping Ganache from our integ tests now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving but I think @Yaiba should take a look since he knows more on this
We should make this change before we make the release branch. Our hardhat dockerfile is here: https://github.com/kwilteam/hardhat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This replaces Ganache with Hardhat.
Ganache project is now dead, and the advice is to migrate to hardhat: https://consensys.io/blog/consensys-announces-the-sunset-of-truffle-and-ganache-and-new-hardhat
Several things were done to accomplish this:
kwildb/hardhat
Dockerfile repo and pushed to Hubeth_maxPriorityFeePerGas
is not supported by Hardhat (it's a go-ethereum invention, not in the RPC spec): transact() attempts to use unsupported eth_maxPriorityFeePerGas via JSON RPC on Kovan ethereum/go-ethereum#23479. We must set the dynamic transaction fee caps, otherwise the go-ethereum methods try to useeth_maxPriorityFeePerGas
to get the "tip" cap with this non-existent RPCcontract deploy fails if we don't give it a gas limit set because it tries fee estimation for the deployment transaction and errors with "eth_estimateGas: Contract creation without any data provided". I don't know the cause of this bug, but we can work around it.NOTE: back to draft because there are too many hoops to jump through until hardhat is updated for it'seth_call
handling. See #630 (comment)The v2.22.5 release fixed the issues: https://github.com/NomicFoundation/hardhat/releases/tag/hardhat%402.22.5