Fix tests with node 15

[Chocobozzz]

Please after the merge, could you create a patch release?

It blocks node upgrade of projects that uses your library: Chocobozzz/PeerTube#2700

Thanks for your work :)

[coveralls]

Coverage remained the same at 97.531% when pulling b3d30ec on Chocobozzz:hotfix/node-15 into f27cb2b on kwhitley:master.

[rimiti]

@kwhitley Is it possible to merge this PR?

[kontrollanten]

@Chocobozzz Maybe we should remove node 6 support since the CI tests are broken there? I think that all support for node <9 should be removed, but I guess that's out of scope for this PR :)

[rimiti]

@kontrollanten Agreed with you, node v6 could be serenely removed.

Like some other users (I guess) I'd like to use the latest Node LTS version (v14), is it possible for you @kwhitley to push -up this urgent topic?

[rimiti]

👍

[kontrollanten]

As far as I understand the failing tests is due to a race condition in clearing cache cancels expiration callback, both trace backs are pointing to that tests. But I've to insight in how apicache works to understand what's supposed to be tested; by the name it looks like it's testing that the expiration callback isn't called, but by the code it looks like something else. Someone with more knowledge are welcome to help :)

[Chocobozzz]

I fixed the expiration tests

[kwhitley]

Thanks for the fix @Chocobozzz! I got to the failing point yesterday and had to shelve it again...

I'm going to release this (sadly) as a major version, as it absolutely breaks backwards compat (by dropping old Node versions). The only question is whether to even try to maintain restify support within this new scope. If no one uses it, better to drop support along with the old Node versions to simplify the codebase and make future support less painful.

Thoughts?

[kwhitley]

Getting this error with the branch:

Then under restify as well:

[rotsee]

The only question is whether to even try to maintain restify support within this new scope.

FWIW I use this with Restify in production, and would hate to see that support dropped... :/

[Chocobozzz]

@kwhitley I don't have these errors, and neither does travis. What is your nodejs version?

This PR was just fixing tests and add node 15 support, not removing node 6 support. I think we should just merge the test fixes, support node 15 and keep compat' with restify and node 6. They worked in 1.5.2 so I don't see why they would not work anymore now.

[rimiti]

Agreed with what you said @Chocobozzz.

[Chocobozzz]

What do you think @kwhitley?

[rimiti]

LGTM

[vikasg603]

Any update for the new release?
I am using Node 14, and I am continuously getting the warning from npm.

[kwhitley]

Merged and going out tonight... thanks so much @Chocobozzz and everyone else for your patience! <3

Sincerest apologies for how ridiculously long this has taken to push through... I've been swamped with a few other libraries and my upcoming Cloudflare Workers work (on top of full time job)!

Cheers all and thanks again!

[Chocobozzz]

No problem thanks for you work and your lib @kwhitley 😽