Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options don't work #12

Closed
mqklin opened this issue Jul 25, 2017 · 7 comments
Closed

Options don't work #12

mqklin opened this issue Jul 25, 2017 · 7 comments
Assignees

Comments

@mqklin
Copy link

mqklin commented Jul 25, 2017

If I put some options (eg ["captains-log", {"injectScope": false}],) it stops work.
See this PR for example.

@kwelch
Copy link
Owner

kwelch commented Jul 25, 2017

Yes, this I know what this is. I need to work on the defaults/option resolution. Additionally, I want to remove injectScope as a default and move it to experimental as it doesn't work properly. See #10.

I will set some time aside tonight to resolve this.

@kwelch kwelch self-assigned this Jul 25, 2017
@kwelch kwelch closed this as completed in 70e987b Jul 26, 2017
@kwelch
Copy link
Owner

kwelch commented Jul 26, 2017

This was fixed and released as v0.6.1.

Additionally, I have released v0.7.0 that sets injectScope to false by default. See the release notes for a deeper explanation.

@mqklin
Copy link
Author

mqklin commented Jul 26, 2017

Thank you!

@mqklin
Copy link
Author

mqklin commented Jul 26, 2017

Personally I use only injectVariableName (because usually I debug only one file on time, but sometimes many console.log there ), so my config now is ['captains-log', {injectFileName: false}],.

@kwelch
Copy link
Owner

kwelch commented Jul 26, 2017

Ok good to know. If you have any suggestions on how to make that smoother let me know. I prefer to give as much flexibility as possible, but options is an odd time to make the choice.

I am glad you like name injection, that is the main reason I wrote this. I really want to expand it beyond variables, to methods or object properties.

Feel free to open any issues for enhancements as well. Thanks!

@mqklin
Copy link
Author

mqklin commented Aug 1, 2017

Thank you for this very useful plugin, it saves a lot of time.

@kwelch
Copy link
Owner

kwelch commented Aug 1, 2017

I appreciate that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants