Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with eslint-loader #11

Closed
mqklin opened this issue Jul 7, 2017 · 9 comments
Closed

Doesn't work with eslint-loader #11

mqklin opened this issue Jul 7, 2017 · 9 comments
Assignees

Comments

@mqklin
Copy link

mqklin commented Jul 7, 2017

Here is a cut from my webpack config:

{
  test: /\.js$/,
  use: [
    'react-hot-loader',
    'cache-loader',
    {
      loader: 'babel-loader',
      options: {
        cacheDirectory: true,
        presets: [
          ['env', {targets: {browsers: ['last 2 versions']}}],
          'stage-2',
          'react',
        ],
        plugins: [
          'transform-decorators-legacy',
          'transform-react-jsx-self',
          'transform-react-jsx-source',
          'styled-components',
          'captains-log',
        ],
      },
    },
    'eslint-loader',
  ],
  exclude: /node_modules/,
},

If I remove eslint-loader, captains-log works as expected.
I can create an example for reproduce the issue if necessary.

@kwelch kwelch self-assigned this Jul 7, 2017
@kwelch
Copy link
Owner

kwelch commented Jul 7, 2017

Thanks, I will take a look over this coming weekend. Is there a specific error you are getting or does the plugin just no longer function?

@mqklin
Copy link
Author

mqklin commented Jul 7, 2017

Just no longer function

@kwelch
Copy link
Owner

kwelch commented Jul 7, 2017

Good to know, thanks.

@kwelch
Copy link
Owner

kwelch commented Jul 8, 2017

Are you getting build failures? Does you build work if you remove captains-log?

I ask because I added eslint-loader to a side project that I worked on that uses captains-log and I had lint errors which caused the webpack build to fail. I had to scroll through the webpack output to find it though.

Here is the repo I tested with: kwelch/family-feud-game. If this is not your issue, please attach a repo that I can reproduce. Thanks

@kwelch
Copy link
Owner

kwelch commented Jul 15, 2017

@mqklin Did the above help at all or are you still stuck in the water?

@mqklin
Copy link
Author

mqklin commented Jul 15, 2017

@kwelch sorry for the delay.
No, I don't get build failures, captains-log just silent.

I'm not sure why I said the eslint-loader is the problem. I've tried to repeat, and now I'm 100% sure cache-loader causes the problem. Can you please try to run your project with it?

@kwelch
Copy link
Owner

kwelch commented Jul 25, 2017

I was able to give this a go with cache-loader and was still able to see my console statement with added details
image

Here is the repo I attempted with. I used my same (small) repo as before. I have pushed a new branch with the cache loader.

https://github.com/kwelch/family-feud-game/tree/cache-loader

Can you verify with that repo, or supply I repo that I can test against?

@mqklin
Copy link
Author

mqklin commented Jul 25, 2017

I found the bug - doesn't work with options, see PR

@mqklin
Copy link
Author

mqklin commented Jul 25, 2017

So I'll close the issue and open a new one

@mqklin mqklin closed this as completed Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants