fix childOrderingRequiredTag computation logic (#527)

Co-authored-by: zhangli20 <[email protected]>
kwai · Jul 22, 2024 · 6543ad3 · 6543ad3
1 parent 7e170ec
commit 6543ad3
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/spark-extension/src/main/scala/org/apache/spark/sql/blaze/BlazeConvertStrategy.scala b/spark-extension/src/main/scala/org/apache/spark/sql/blaze/BlazeConvertStrategy.scala
@@ -84,12 +84,20 @@ object BlazeConvertStrategy extends Logging {
         .zip(exec.requiredChildOrdering)
         .foreach { case (child, requiredOrdering) =>
           if (requiredOrdering.nonEmpty) {
-            logInfo(s"physical plan [${child.nodeName}] requires ordering: $requiredOrdering")
             child.setTagValue(childOrderingRequiredTag, true)
           }
         }
     }
-    exec.setTagValue(childOrderingRequiredTag, exec.outputOrdering.nonEmpty)
+    exec.foreach {
+      case exec: SortExec =>
+        exec.setTagValue(childOrderingRequiredTag, false)
+      case exec =>
+        if (exec.getTagValue(childOrderingRequiredTag).contains(true)) {
+          exec.children.foreach { child =>
+            child.setTagValue(childOrderingRequiredTag, child.outputOrdering.nonEmpty)
+          }
+        }
+    }
 
     // execute some special strategies
     removeInefficientConverts(exec)