Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding last log field to replace ifttt events #171

Merged
merged 1 commit into from
Jan 7, 2024
Merged

Adding last log field to replace ifttt events #171

merged 1 commit into from
Jan 7, 2024

Conversation

carsso
Copy link
Contributor

@carsso carsso commented Dec 30, 2023

Because nuki is dropping IFTTT support, it is now impossible to trigger actions based on open/unlock/lock events.
This PR adds a new last_log field with the name of the thing or person that triggered the last action (with some extra attributes to get the action type and timestamp).
Last unlock user field is kept unchanged to ensure retro-compatibility with old automations relying on that field.

@carsso
Copy link
Contributor Author

carsso commented Jan 1, 2024

Add exceptions handling, to put back old data when request to nuki web fails.

@kvj
Copy link
Owner

kvj commented Jan 1, 2024

Looks good! Anything else would you like to add or should I merge the PR?

@carsso
Copy link
Contributor Author

carsso commented Jan 1, 2024

Maybe that's worth testing a few days how it reacts with the exception handling as I added it just minutes ago.
But up to you, I am running that version on my HA and watching behaviour carefully.

@kvj
Copy link
Owner

kvj commented Jan 1, 2024

ok, please let me know when you think it's ready to be merged

@carsso
Copy link
Contributor Author

carsso commented Jan 4, 2024

Seems to be working fine since two days. Feel ready to merge when you want to :)
I'll continue watching carefully how it behaves and I'll suggest a patch if anything goes wrong.

@carsso
Copy link
Contributor Author

carsso commented Jan 7, 2024

@kvj Hello, it's been a week, everything still working as expected without any issue. You can merge when you want.

@kvj kvj merged commit 99d1232 into kvj:main Jan 7, 2024
@kvj
Copy link
Owner

kvj commented Jan 7, 2024

@carsso could you please check the latest main branch? if it works as expected I'll bump new release

@carsso
Copy link
Contributor Author

carsso commented Jan 7, 2024

@kvj Sure, will deploy main on my HA right away.

@carsso
Copy link
Contributor Author

carsso commented Jan 7, 2024

@kvj Seems to be working fine with main branch as of now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants