Add more hints when decrypting AES with an invalid key #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before merging this needs tests. Otherwise looks good 👍 |
|
I've grepped decrypt in tests/ and haven't found anything. Where do you think should i add them? |
|
Each type has its own tests. You can find the encrypted type tests in https://github.com/kvesteri/sqlalchemy-utils/blob/master/tests/types/test_encrypted.py and add your tests there. |
Also the test before asserts the same thing is a pytz.tzfile.DstTzInfo
|
Updated PR with test plus removed an assert on an unrelated test that makes the build fail |
|
Friendly ping |
|
Thanks for the PR! 🚋 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #275