Fixes for a couple of issues related to using multiple schemas #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good. Could you also add a test for this and remove the unnecessary commits? |
|
Added tests and fixed a few related issues I found while getting the tests to work. |
|
Are there any plans to merge this patch? PostgreSQL's schema system makes life so much easier, and it would really help if sqlalchemy-continuum could work with it. |
|
Thanks for the PR! 🚋 |
|
Relased as part of 1.3.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my environment we have lots of tables with different schemas residing in a metadata that has yet another schema. This pull request includes the changes required to get continuum working in that scenario.