Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies update #947

Merged
merged 2 commits into from
Aug 28, 2017
Merged

Dependencies update #947

merged 2 commits into from
Aug 28, 2017

Conversation

scottinet
Copy link
Contributor

@scottinet scottinet commented Aug 28, 2017

Description

  • Now uses Kuzzle common objects v3.0.6
  • Elasticsearch client now refuses the 5.x API version => changed to 5.4
  • Fix new errors detected by eslint v4 (mainly indentation and multiple spaces lint errors)
  • Cucumber has NOT been upgraded: the current version is 3.0.0 but it is currently broken and unusable in our project

Other changes

Some commands of the CLI were broken due to recent changes to the getEventName method of the funnel controller. This is now fixed.

@scottinet scottinet self-assigned this Aug 28, 2017
@scottinet scottinet added the changelog:exclude Internal changes only label Aug 28, 2017
@codecov-io
Copy link

codecov-io commented Aug 28, 2017

Codecov Report

Merging #947 into 1.x will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              1.x     #947      +/-   ##
==========================================
+ Coverage   94.77%   94.77%   +<.01%     
==========================================
  Files         134      134              
  Lines        7218     7219       +1     
==========================================
+ Hits         6841     6842       +1     
  Misses        377      377
Impacted Files Coverage Δ
default.config.js 100% <ø> (ø) ⬆️
lib/api/core/plugins/pluginsManager.js 84.3% <ø> (ø) ⬆️
lib/api/dsl/storage/index.js 93.78% <ø> (ø) ⬆️
lib/api/core/validation/index.js 99.67% <ø> (ø) ⬆️
lib/api/core/entrypoints/embedded/index.js 96.87% <100%> (+0.01%) ⬆️
lib/api/cli/index.js 96.15% <100%> (ø) ⬆️
lib/api/core/swagger.js 97.05% <100%> (ø) ⬆️
lib/api/dsl/transform/canonical.js 87.24% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6e0de9...571ed55. Read the comment docs.

@scottinet scottinet merged commit 9eaa439 into 1.x Aug 28, 2017
@scottinet scottinet deleted the deps-update branch August 28, 2017 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:exclude Internal changes only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants