-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove _id from bulk:write 2e route #1314
Conversation
Codecov Report
@@ Coverage Diff @@
## 1-dev #1314 +/- ##
==========================================
- Coverage 93.79% 6.78% -87.02%
==========================================
Files 98 98
Lines 6967 6971 +4
==========================================
- Hits 6535 473 -6062
- Misses 432 6498 +6066
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## 1-dev #1314 +/- ##
=====================================
Coverage 93.8% 93.8%
=====================================
Files 98 98
Lines 6991 6991
=====================================
Hits 6558 6558
Misses 433 433
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why this route should be removed.
To me, it is quite consistent with the document:create|replace
routes.
@benoitvidis > this started from this comment in the corresponding documentation PR: kuzzleio/documentation#300 (comment) The routes you mention are old, and created prior to our own HTTP router. Passing a document ID in the querystring is now free, and having multiple URLs because of an optional argument doesn't seem clean to me. Thinking of that, I wonder if perhaps we should deprecate the duplicated routes for old API actions 🤔 |
@scottinet Yes I think we should deprecate other duplicated routes |
What does this PR do ?
Remove the second route for
bulk:write
. The _id is now a query string parameter and not part of the urlHow should this be manually tested?
...
Other changes
Boyscout