feat(elasticsearch8): tests unit are now okay

.eslintrc.json

@@ -7,7 +7,7 @@
     "plugin:kuzzle/node"
   ],
   "rules": {
-    "sort-keys": "warn",
-    "kuzzle/array-foreach": "warn"
+    "sort-keys": "off",
+    "kuzzle/array-foreach": "off"
   }
 }

lib/core/backend/backendStorage.ts

@@ -34,9 +34,17 @@ export class BackendStorage extends ApplicationManager {
    * @param clientConfig Overload configuration for the underlaying storage client
    */
   get StorageClient(): new (clientConfig?: any) => any {
+    const kuzzle = this._kuzzle;
+
     if (!this._Client) {
       this._Client = function ESClient(clientConfig: JSONObject = {}) {
-        return this.getElasticsearchClient(clientConfig);
+        return Elasticsearch.buildClient(
+          {
+            ...kuzzle.config.services.storageEngine.client,
+            ...clientConfig,
+          },
+          kuzzle.config.services.storageEngine.majorVersion,
+        );
       } as unknown as new (clientConfig?: any) => any;
     }
 
@@ -48,17 +56,15 @@ export class BackendStorage extends ApplicationManager {
    * (Currently Elasticsearch)
    */
   get storageClient(): any {
+    const kuzzle = this._kuzzle;
+
     if (!this._client) {
-      this._client = this.getElasticsearchClient();
+      this._client = Elasticsearch.buildClient(
+        kuzzle.config.services.storageEngine.client,
+        kuzzle.config.services.storageEngine.majorVersion,
+      );
     }
 
     return this._client;
   }
-
-  getElasticsearchClient(clientConfig?: JSONObject): any {
-    return Elasticsearch.buildClient(
-      { ...this._kuzzle.config.services.storageEngine.client, ...clientConfig },
-      this._kuzzle.config.services.storageEngine.majorVersion,
-    );
-  }
 }

lib/core/storage/clientAdapter.js

@@ -203,6 +203,7 @@ class ClientAdapter {
      * @return {Promise}
      * @throws
      */
+
     global.kuzzle.onAsk(
       `core:storage:${this.scope}:collection:create`,
       (index, collection, opts, creationOptions) =>

lib/core/storage/storageEngine.js

@@ -21,8 +21,6 @@
 
 "use strict";
 
-const Bluebird = require("bluebird");
-
 const kerror = require("../../kerror").wrap("services", "storage");
 const ClientAdapter = require("./clientAdapter");
 const scopeEnum = require("./storeScopeEnum");
@@ -42,11 +40,12 @@ class StorageEngine {
    * @returns {Promise}
    */
   async init() {
-    await Bluebird.all([this.public.init(), this.private.init()]);
+    await Promise.all([this.public.init(), this.private.init()]);
 
     const privateIndexes = this.private.cache.listIndexes();
+    const publicIndexes = this.public.cache.listIndexes();
 
-    for (const publicIndex of this.public.cache.listIndexes()) {
+    for (const publicIndex of publicIndexes) {
       if (privateIndexes.includes(publicIndex)) {
         throw kerror.get("index_already_exists", "public", publicIndex);
       }