Add ability to define mapping policy for new fields #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 2-dev #502 +/- ##
========================================
Coverage ? 81.39%
========================================
Files ? 34
Lines ? 774
Branches ? 0
========================================
Hits ? 630
Misses ? 144
Partials ? 0
Continue to review full report at Codecov.
|
Njuelle
suggested changes
Mar 8, 2019
| @@ -86,7 +86,7 @@ | |||
| <div class="col s7 m8 l9" v-if="error"> | |||
| <div class="card error red-color"> | |||
| <i class="fa fa-times dismiss-error" @click="dismissError()"></i> | |||
| <p v-html="error"></p> | |||
| <p class="white-text" v-html="error"></p> | |||
There was a problem hiding this comment.
You add a white-text class here, and the css rule apply to .error-text. is it normal?
(the same for each error card you modified)
| @@ -143,6 +143,9 @@ | |||
| padding: 8px 12px; | |||
| margin: 0; | |||
| } | |||
| .error-text { | |||
Co-Authored-By: Aschen <[email protected]>
…om:kuzzleio/kuzzle-admin-console into add-ability-to-restrict-collection-mapping
Njuelle
approved these changes
Mar 12, 2019
Aschen
added a commit
to kuzzleio/kuzzle
that referenced
this pull request
Apr 25, 2019
Adds the ability to define the `dynamic` property for collection mapping. This property can take 3 values: - "true": Stores the document and updates the collection mapping with inferred type - "false": Stores the document and does not update the collection mapping (fields are not indexed) - "strict": Rejects document See https://www.elastic.co/guide/en/elasticsearch/guide/current/dynamic-mapping.html This is configurable in the `kuzzlerc` within the `server.db.dynamic` property. The default value is `true` which allows the user to push arbitrary documents to Kuzzle and Elasticsearch will try to infer the corresponding mapping. (This is the current behaviour in Kuzzle) Admin-Console (wip): kuzzleio/kuzzle-admin-console#502 Documentation: kuzzleio/documentation#271 ## Other changes Fixed the usage of the `_meta` property for ES collection. This property must be passed to each call to `putMapping`. See #1268 chmod 777 on `node_modules/` because I'm tired of doing `sudo chmod +x node_modules/.bin/*` to run test locally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Allows the definition of the
dynamicproperty for the mappings.Now users have to specify the root
propertyfield for mappings:This PR is related to kuzzleio/kuzzle#1257 but the admin console will work with older kuzzle version too.
How should this be manually tested?
dynamicproperty tostrictat the same level aspropertiesOther changes