Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable test NodeUpdateTest.UpdateSameRowRedundtanly for in mem mode tests #4911

Merged
merged 2 commits into from
Feb 14, 2025

Conversation

royi-luo
Copy link
Collaborator

@royi-luo royi-luo commented Feb 14, 2025

Description

The test NodeUpdateTest.UpdateSameRowRedundtanly was introduced in the PR #4895. However the fix in that PR does not apply to in-memory mode since we don't checkpoint in in-memory mode so I'm disable the test for now for in-mem mode only.

Contributor agreement

@royi-luo royi-luo self-assigned this Feb 14, 2025
@acquamarin
Copy link
Collaborator

@benjaminwinger Do you have an idea, i saw the CI failures after your PR.
https://github.com/kuzudb/kuzu/actions/runs/13333827278/job/37244558396

@royi-luo royi-luo force-pushed the royi/fix-node-update-test branch from 873da30 to e6ca092 Compare February 14, 2025 20:16
@royi-luo royi-luo changed the title Increase buffer pool size for node update test Disable test NodeUpdateTest.UpdateSameRowRedundtanly for in mem mode tests Feb 14, 2025
test/storage/node_update_test.cpp Outdated Show resolved Hide resolved
@royi-luo royi-luo force-pushed the royi/fix-node-update-test branch from e6ca092 to 2c95729 Compare February 14, 2025 20:23
Copy link

Benchmark Result

Master commit hash: a88d57e3d3a1323feb88a31f946171cd17f20ac9
Branch commit hash: 3ab54a80d9f08a56b28d1406726a41c99be25993

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 717.10 724.38 -7.28 (-1.01%)
aggregation q28 6347.09 6365.18 -18.09 (-0.28%)
filter q14 119.82 126.15 -6.33 (-5.02%)
filter q15 117.77 125.06 -7.28 (-5.82%)
filter q16 297.69 301.31 -3.62 (-1.20%)
filter q17 441.08 446.32 -5.23 (-1.17%)
filter q18 1937.61 1939.86 -2.25 (-0.12%)
filter zonemap-node 84.72 90.69 -5.97 (-6.58%)
filter zonemap-node-lhs-cast 81.08 88.98 -7.90 (-8.88%)
filter zonemap-node-null 82.40 88.59 -6.19 (-6.99%)
filter zonemap-rel 5587.96 5422.24 165.72 (3.06%)
fixed_size_expr_evaluator q07 569.38 578.36 -8.97 (-1.55%)
fixed_size_expr_evaluator q08 792.82 807.96 -15.14 (-1.87%)
fixed_size_expr_evaluator q09 797.45 811.59 -14.14 (-1.74%)
fixed_size_expr_evaluator q10 231.90 245.64 -13.74 (-5.59%)
fixed_size_expr_evaluator q11 224.95 238.22 -13.27 (-5.57%)
fixed_size_expr_evaluator q12 217.24 236.79 -19.54 (-8.25%)
fixed_size_expr_evaluator q13 1453.96 1456.47 -2.52 (-0.17%)
fixed_size_seq_scan q23 101.48 117.14 -15.66 (-13.37%)
join q29 747.31 732.30 15.01 (2.05%)
join q30 10037.66 10505.58 -467.91 (-4.45%)
join q31 6.46 7.93 -1.47 (-18.60%)
join SelectiveTwoHopJoin 57.76 57.26 0.50 (0.87%)
ldbc_snb_ic q35 2639.80 2603.11 36.70 (1.41%)
ldbc_snb_ic q36 484.48 482.67 1.81 (0.38%)
ldbc_snb_is q32 6.63 5.32 1.31 (24.62%)
ldbc_snb_is q33 15.96 17.42 -1.46 (-8.38%)
ldbc_snb_is q34 1.21 1.10 0.11 (10.18%)
multi-rel multi-rel-large-scan 1339.91 1642.31 -302.39 (-18.41%)
multi-rel multi-rel-lookup 23.42 21.48 1.94 (9.02%)
multi-rel multi-rel-small-scan 98.80 92.81 6.00 (6.46%)
order_by q25 119.63 131.07 -11.44 (-8.73%)
order_by q26 444.95 454.88 -9.93 (-2.18%)
order_by q27 1393.23 1406.59 -13.36 (-0.95%)
recursive_join recursive-join-bidirection 310.46 310.91 -0.45 (-0.14%)
recursive_join recursive-join-dense 7401.71 7376.56 25.15 (0.34%)
recursive_join recursive-join-path 24358.54 24322.43 36.11 (0.15%)
recursive_join recursive-join-sparse 1057.63 1047.53 10.10 (0.96%)
recursive_join recursive-join-trail 7354.21 7353.06 1.16 (0.02%)
scan_after_filter q01 163.94 170.35 -6.41 (-3.76%)
scan_after_filter q02 147.62 160.39 -12.77 (-7.96%)
shortest_path_ldbc100 q37 88.93 88.63 0.30 (0.34%)
shortest_path_ldbc100 q38 377.97 371.13 6.85 (1.84%)
shortest_path_ldbc100 q39 68.16 66.35 1.81 (2.73%)
shortest_path_ldbc100 q40 457.20 426.33 30.87 (7.24%)
var_size_expr_evaluator q03 2079.09 2082.96 -3.87 (-0.19%)
var_size_expr_evaluator q04 2230.63 2225.81 4.82 (0.22%)
var_size_expr_evaluator q05 2603.80 2628.58 -24.78 (-0.94%)
var_size_expr_evaluator q06 1321.03 1334.23 -13.20 (-0.99%)
var_size_seq_scan q19 1448.48 1464.03 -15.55 (-1.06%)
var_size_seq_scan q20 2483.27 2346.12 137.15 (5.85%)
var_size_seq_scan q21 2284.69 2278.22 6.47 (0.28%)
var_size_seq_scan q22 123.56 127.74 -4.18 (-3.28%)

@royi-luo royi-luo merged commit cf860af into master Feb 14, 2025
21 of 23 checks passed
@royi-luo royi-luo deleted the royi/fix-node-update-test branch February 14, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants