clean update info during node group checkpoint

kuzudb · Feb 14, 2025 · 07e058e · 07e058e
1 parent 4ddee1b
commit 07e058e
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 4 deletions.
diff --git a/src/storage/store/node_group.cpp b/src/storage/store/node_group.cpp
@@ -445,6 +445,7 @@ std::unique_ptr<ChunkedNodeGroup> NodeGroup::checkpointInMemAndOnDisk(MemoryMana
         std::make_unique<ChunkedNodeGroup>(*chunkedGroups.getGroup(lock, 0), state.columnIDs);
     KU_ASSERT(checkpointedChunkedGroup->getResidencyState() == ResidencyState::ON_DISK);
     checkpointedChunkedGroup->resetNumRowsFromChunks();
+    checkpointedChunkedGroup->resetVersionAndUpdateInfo();
     return checkpointedChunkedGroup;
 }
 

diff --git a/src/storage/store/update_info.cpp b/src/storage/store/update_info.cpp
@@ -4,7 +4,6 @@
 
 #include "common/exception/runtime.h"
 #include "common/vector/value_vector.h"
-#include "storage/buffer_manager/memory_manager.h"
 #include "storage/storage_utils.h"
 #include "storage/store/column_chunk_data.h"
 #include "transaction/transaction.h"

diff --git a/test/storage/node_update_test.cpp b/test/storage/node_update_test.cpp
@@ -14,9 +14,10 @@ class NodeUpdateTest : public EmptyDBTest {
 };
 
 TEST_F(NodeUpdateTest, UpdateSameRow) {
-    ASSERT_TRUE(conn->query("CREATE NODE TABLE IF NOT EXISTS Product (item STRING, price INT64, "
-                            "PRIMARY KEY (item))")
-                    ->isSuccess());
+    ASSERT_TRUE(
+        conn->query("CREATE NODE TABLE IF NOT EXISTS Product (item STRING, price INT64, "
+                    "PRIMARY KEY (item))")
+            ->isSuccess());
     ASSERT_TRUE(conn->query("CREATE (n:Product {item: 'watch'}) SET n.price = 100")->isSuccess());
     ASSERT_TRUE(
         conn->query("MATCH (n:Product) WHERE n.item = 'watch' SET n.price = 200")->isSuccess());
@@ -27,5 +28,17 @@ TEST_F(NodeUpdateTest, UpdateSameRow) {
     ASSERT_EQ(res->getNext()->getValue(0)->val.int64Val, 300);
 }
 
+TEST_F(NodeUpdateTest, UpdateSameRowRedundtanly) {
+    ASSERT_TRUE(
+        conn->query("CREATE NODE TABLE test (id SERIAL PRIMARY KEY, name STRING, prop STRING);")
+            ->isSuccess());
+    for (auto i = 0u; i < 100; i++) {
+        ASSERT_TRUE(
+            conn->query("MERGE (s:test {name: 'chunkFileNames'}) ON MATCH SET "
+                        "s.prop=lpad('sss', 1000000, 'x');")
+                ->isSuccess());
+    }
+}
+
 } // namespace testing
 } // namespace kuzu