IOInterface typing wrapper for lib.data signatures #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The boilerplate reduction is nice, but this is a little bit hacky. Maybe, instead of a custom |
lekcyjna123
reviewed
Oct 5, 2024
| "master_wb": Out(WishboneSignature(wb_params)), | ||
| "slaves": In(WishboneSignature(wb_params)).array(num_slaves), | ||
| "master_wb": Out(WishboneInterface(wb_params).signature), | ||
| "slaves": Out(WishboneInterface(wb_params).signature).array(num_slaves), |
There was a problem hiding this comment.
Why In was changed to Out?
| ] | ||
|
|
||
|
|
||
| class IOSignal(Value): |
There was a problem hiding this comment.
As discussed on the meeting it would be great to have the name changed.
| ] | ||
|
|
||
|
|
||
| class IOSignal(Value): |
There was a problem hiding this comment.
Doc string will be welcome
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
amaranth.lib.dataSignatures with typing comes with some boilerplate and repetition :(I came up with a class that can be used both for typing and to get amaranth
Signaturefor use inComponentconstructor.It works by crating a class with
IOSignalfields declared asself.in constructor, so it can be directly for typechecking.IOSignaltype derivesValuewith additonal shape and direction information.IOInterfaceis never used globally, but is intended only for interface typing. Those signals will be filled with actual objects atsuper().__init__(...Componentconstructor (that gets Signature from generatedIOInterface.signature). NestedIOInterfacesare supported.It is a bit hacky, but what do you think?