-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate generating compatibility table for different logstash version #160
Conversation
sweep: instead of modifying existing docker-compose i would like you to create a separate one, prefereably with other default ports and with other variables responsible for setting up custom ports. it would be nice if i could either generate a custom docker-compose for this matter, or dynamically specify logstash versions to test on demand. |
actually i dont need logstash ports in docker-compose-compatibility |
GitHub actions yielded the following error. The command that failed is
Please note that the error message "fatal: ref HEAD is not a symbolic ref" is not related to the This is likely a linting or type-checking issue with the source code. Update the code the changes and avoid modifying the existing tests. |
This part: metric1Available=$(jq -r '.Metric1' <<< "$metrics")
metric2Available=$(jq -r '.Metric2' <<< "$metrics")
metric3Available=$(jq -r '.Metric3' <<< "$metrics") seems wrong metrics could be fetched dynamically, you can see the file add_metrics_to_readme.sh as a reference |
I did not want you to modify my wait-for-compose command, feel free to create another one, but leave this one as-is |
you forgot to rename generate_compatibility_table.go to generate_compatibility_table.sh |
GitHub actions yielded the following error. The command that failed is
Please note that the logs provided are truncated and may not include all the relevant information. This is likely a linting or type-checking issue with the source code. Update the code the changes and avoid modifying the existing tests. |
GitHub actions yielded the following error. The command that failed is
The command that failed is
The command that failed is
There are a lot of errors. This is likely due to a small parsing issue or a missing import with the files changed in the PR. This is likely a linting or type-checking issue with the source code. Update the code the changes and avoid modifying the existing tests. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #160 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 589 589
=========================================
Hits 589 589 ☔ View full report in Codecov by Sentry. |
This part
is just wrong, you cannot use docker service ls, you have to fetch services from docker-compose-compatibility.yml also
metrics should be fetched dynamically |
I would like you to rollback Makefile to the original one. Lets now focus on docker-compose-compatibility and generate_compatibility_table files. Lets not affect existing ones |
Closing it for now, I will create the same thing fasterr |
Description
This PR automates the process of generating a compatibility table for different versions of Logstash. It includes the following changes:
docker-compose.yml
file to include multiple services, each running a different version of Logstash. This allows for testing the compatibility of metrics with different Logstash versions simultaneously.scripts/generate_compatibility_table.go
, that iterates over the different Logstash versions in the development environment, checks the compatibility of metrics, and generates a markdown file with the compatibility table.COMPATIBILITY.md
, which is generated by the script and contains the compatibility table for the metrics across different versions of Logstash.Makefile
to include a new command that runs the script for generating the compatibility table.Summary of Changes
docker-compose.yml
to include multiple Logstash versions for testing.scripts/generate_compatibility_table.go
to automate the process of generating the compatibility table.COMPATIBILITY.md
to store the generated compatibility table.Makefile
to include a new command for running the compatibility table generation script.Fixes #158.
To checkout this PR branch, run the following command in your terminal:
To get Sweep to edit this pull request, leave a comment below or in the code. Leaving a comment in the code will only modify the file but commenting below can change the entire PR.