Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implemented rename enclave method in container engine lib #755

Merged
merged 5 commits into from
Jun 22, 2023

Conversation

leoporoli
Copy link
Contributor

Description:

Implemented rename enclave method in container engine lib

Is this change user facing?

NO

References (if applicable):

This is part of the enclave pool project, more context here: https://www.notion.so/kurtosistech/Enclave-Pool-Project-7273552e53e44b0f931a57568cd170a0

@leoporoli leoporoli requested a review from gbouv June 21, 2023 21:21
Copy link
Contributor

@gbouv gbouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm too lazy to dive into the code, or even try it on minikube, but is the namespace the only thing that we tag with the enclave name label? We don't tag the APIC pod for example?

@leoporoli
Copy link
Contributor Author

leoporoli commented Jun 22, 2023

I'm too lazy to dive into the code, or even try it on Minikube, but is the namespace the only thing that we tag with the enclave name label? We don't tag the APIC pod for example.

@gbouv good question, these are the enclave's labels and annotations:
image

I think that it will be necessary to update these: kurtosistech.com/enclave-id, kurtosistech.com/guid, and kurtosistech.com/id which in fact have the same value

And the APIC pod also contains the enclave-id, so I think that will be necessary to update this too:
image

And the APIC service

image

mmm thinking on it again, I think it's not necessary to update the enclave-uuid it can continue being the same, so won't be necessary to update any other K8s resource if I'm not wrong

@leoporoli leoporoli enabled auto-merge (squash) June 22, 2023 19:23
@leoporoli leoporoli merged commit f1570f7 into main Jun 22, 2023
@leoporoli leoporoli deleted the lporoli/rename-namespaces branch June 22, 2023 19:46
victorcolombo pushed a commit that referenced this pull request Jun 26, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.80.1](0.80.0...0.80.1)
(2023-06-26)


### Features

* Add Rust protobuf bindings
([#765](#765))
([0e47003](0e47003))
* added wait to run_sh task.
([#750](#750))
([8c2b697](8c2b697))
* Implemented rename enclave method in container engine lib
([#755](#755))
([f1570f7](f1570f7))
* Persist enclave plan in the Starlark executor memory
([#757](#757))
([2c3d74e](2c3d74e))
* Start and Stop service Starlark instructions for K8S
([#756](#756))
([fb3e922](fb3e922))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: kurtosisbot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants