fix!: removed workdir from run_sh and fixed some typos on the doc #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
18f0082
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3ca1c303.kurtosis-docs.pages.dev |
| Branch Preview URL: | https://pk-fix-workdir-bug.kurtosis-docs.pages.dev |
|
@Peeeekay lets give this a better title :) |
h4ck3rk3y
reviewed
Jun 16, 2023
core/server/api_container/server/startosis_engine/kurtosis_instruction/run_sh/run_sh.go
Outdated
Show resolved
Hide resolved
h4ck3rk3y
approved these changes
Jun 16, 2023
core/server/api_container/server/startosis_engine/kurtosis_instruction/run_sh/run_sh.go
Outdated
Show resolved
Hide resolved
internal_testsuites/golang/testsuite/startosis_run_sh_task_test/run_task_sh_task_test.go
Outdated
Show resolved
Hide resolved
Peeeekay
changed the title
Peeeekay
changed the title
Peeeekay
force-pushed
the
pk/fix_workdir_bug
branch
from
ea1c41c to
90be09e
Compare
h4ck3rk3y
approved these changes
Jun 20, 2023
internal_testsuites/golang/testsuite/startosis_run_sh_task_test/run_task_sh_task_test.go
Outdated
Show resolved
Hide resolved
Peeeekay
force-pushed
the
pk/fix_workdir_bug
branch
from
7b3ec7e to
18f0082
Compare
h4ck3rk3y
pushed a commit
that referenced
this pull request
Jun 21, 2023
🤖 I have created a release *beep* *boop* --- ## [0.79.0](0.78.5...0.79.0) (2023-06-21) ### ⚠ BREAKING CHANGES * removed workdir from run_sh and fixed some typos on the doc ([#739](#739)) ### Features * allow to pop a shell on Kubernetes ([#748](#748)) ([3c706e5](3c706e5)) ### Bug Fixes * removed workdir from run_sh and fixed some typos on the doc ([#739](#739)) ([6406f10](6406f10)) * Support for reconnects in the Gateway port forwarder ([#736](#736)) ([4944ccd](4944ccd)), closes [#726](#726) * typos ([#742](#742)) ([800e523](800e523)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have removed the
workdirfrom run_sh task to keep it simple. The shell command will either run from root directory or workdir set in the image now. This also means that file artifacts will be accessed using absolute paths, not relative paths.Previously,
result = plan.run_sh(...)would returnresult.file_aritifactsbut now I fixed the typo for consistency and it returnsresult.files_artifactsand this can be used to access the files artifacts from the task.