Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow offline mode with local images #1299

Closed
barnabasbusa opened this issue Sep 14, 2023 · 4 comments
Closed

Allow offline mode with local images #1299

barnabasbusa opened this issue Sep 14, 2023 · 4 comments
Assignees
Labels

Comments

@barnabasbusa
Copy link
Collaborator

Background & motivation

I know I have requested a feature to always pull images, however, it would be great if there would be a mode where this would not be enabled by default.

Desired behaviour

It would be great if there would be a flag e.g: --offline which disabled all image pulls and only works with local images.

Basically to allow kurtosis to operate in an offline only mode. (Very useful when your internet connection is unreliable, and you know that you already have the images locally available).

How important is this to you?

Painful; the lack of this feature makes using Kurtosis frictionful.

@github-actions github-actions bot added the painful Painful bug label Sep 14, 2023
@mieubrisse
Copy link
Collaborator

Hey @barnabasbusa , I'm keen to grab a chat with you to see explicitly what were the symptoms you experienced. I think there's the opportunity to put some smart logic in the product

@mieubrisse
Copy link
Collaborator

Related to, but not superseded by, #1307

@h4ck3rk3y
Copy link
Contributor

hey @mieubrisse I have assigned this to you as Tedi told me there's some design work going on on this;

@leeederek leeederek assigned lostbean and unassigned mieubrisse Oct 4, 2023
github-merge-queue bot pushed a commit that referenced this issue Oct 28, 2023
## Description:
This PR adds a new cli argument to control how to download the latest
images.

## Is this change user facing?
YES

## References (if applicable):
This PR is aimed to address #1299
github-merge-queue bot pushed a commit that referenced this issue Oct 31, 2023
## Description:
Improve description of the image-download flag in both CLI help and
docs.

## Is this change user facing?
YES

## References (if applicable):
- fix on #1495 for #1299

---------

Co-authored-by: Derek <[email protected]>
@leeederek
Copy link
Contributor

Hey @barnabasbusa, we've merged #1495 and #1660! Kurtosis can now be used while offline so long as your images are locally cached. By default, Kurtosis will not attempt to fetch new image tags if an image already exists locally.

Can we close out this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants