Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unintended version specification in execution-environment.yml #385

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Conversation

xWTF
Copy link
Contributor

@xWTF xWTF commented Aug 18, 2024

Problem

The current version specification, according to PEP 440, would match the following versions:

ansible-core >= 2.15 (aka == 2.*)
ansible-runner >= 2.3 (aka == 2.*)

Which would install the following versions atm:

#8 1.077 Collecting ansible-core~=2.15
#8 1.234   Downloading ansible_core-2.17.3-py3-none-any.whl (2.2 MB)
#8 1.538      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 2.2/2.2 MB 7.4 MB/s eta 0:00:00
#8 1.785 Collecting ansible-runner~=2.3
#8 1.823   Downloading ansible_runner-2.4.0-py3-none-any.whl (79 kB)
#8 1.831      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 79.7/79.7 kB 13.8 MB/s eta 0:00:00

However, according to this line and the container name, I assume that you wanted to build 2.15.* instead of the latest 2.* ee.

Having the latest versions installed caused a serious compatibility break on old systems (specifically, CentOS 7) because they usually have Python 3.6 installed, and according to ansible-core release note and ansible-runner release note, these would fail on Python 3.6 (throw Syntax Errors).

Solution

This PR fixes the version specifications so they would install the following versions instead:

#8 0.916 Collecting ansible-core~=2.15.0
#8 1.072   Downloading ansible_core-2.15.12-py3-none-any.whl (2.3 MB)
#8 1.380      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 2.3/2.3 MB 7.4 MB/s eta 0:00:00
#8 1.627 Collecting ansible-runner~=2.3.0
#8 1.665   Downloading ansible_runner-2.3.6-py3-none-any.whl (81 kB)
#8 1.673      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 81.6/81.6 kB 18.6 MB/s eta 0:00:00

@kurokobo
Copy link
Owner

@xWTF
Good catch, thank you for fixing this!

@kurokobo kurokobo merged commit 5bed268 into kurokobo:main Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants