Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(containerd): only build cgroups on linux #7408

Merged
merged 1 commit into from
Aug 1, 2023
Merged

fix(containerd): only build cgroups on linux #7408

merged 1 commit into from
Aug 1, 2023

Conversation

slonka
Copy link
Contributor

@slonka slonka commented Aug 1, 2023

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@slonka slonka requested a review from a team as a code owner August 1, 2023 13:43
@slonka slonka requested review from Automaat and bartsmykla and removed request for a team August 1, 2023 13:43
@slonka slonka added ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change) ci/skip-e2e-test PR: Don't run e2e tests and removed ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change) labels Aug 1, 2023
@slonka slonka merged commit 8690b89 into kumahq:master Aug 1, 2023
@slonka slonka added the backport label Aug 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023 •
edited
Loading

backporting to release-2.2 with action

backporting to release-2.0 with action
backporting to release-2.1 with action
backporting to release-1.8 with action
backporting to release-2.3 with action

@kumahq kumahq bot mentioned this pull request Aug 2, 2023
Merged
kumahq bot pushed a commit that referenced this pull request Aug 2, 2023
@slonka @kumahq
fix(containerd): only build cgroups on linux (#7408)
37e5d7f 
Signed-off-by: slonka <[email protected]>
kumahq bot pushed a commit that referenced this pull request Aug 2, 2023
@slonka @kumahq
fix(containerd): only build cgroups on linux (#7408)
ab65cb3 
Signed-off-by: slonka <[email protected]>
This was referenced Aug 2, 2023
Merged
Closed
kumahq bot pushed a commit that referenced this pull request Aug 2, 2023
@slonka @kumahq
fix(containerd): only build cgroups on linux (#7408)
8f27b94 
Signed-off-by: slonka <[email protected]>
@kumahq kumahq bot mentioned this pull request Aug 2, 2023
Merged
kumahq bot pushed a commit that referenced this pull request Aug 2, 2023
@slonka @kumahq
fix(containerd): only build cgroups on linux (#7408)
89e1aef 
Signed-off-by: slonka <[email protected]>
@kumahq kumahq bot mentioned this pull request Aug 2, 2023
Merged
kumahq bot pushed a commit that referenced this pull request Aug 2, 2023
@slonka @kumahq
fix(containerd): only build cgroups on linux (#7408)
4ac55c3 
Signed-off-by: slonka <[email protected]>
michaelbeaumont pushed a commit that referenced this pull request Aug 2, 2023
@slonka @michaelbeaumont
fix(containerd): only build cgroups on linux (#7408)
bb15207 
Signed-off-by: slonka <[email protected]>
michaelbeaumont pushed a commit that referenced this pull request Aug 2, 2023
@slonka @michaelbeaumont
fix(containerd): only build cgroups on linux (#7408)
9980eef 
Signed-off-by: slonka <[email protected]>
michaelbeaumont added a commit to michaelbeaumont/kuma that referenced this pull request Aug 2, 2023
@michaelbeaumont
build(formatting): fix indentation from kumahq#7408
0257610 
Signed-off-by: Mike Beaumont <[email protected]>
michaelbeaumont pushed a commit that referenced this pull request Aug 2, 2023
@slonka @michaelbeaumont
fix(containerd): only build cgroups on linux (#7408)
4fe0147 
Signed-off-by: slonka <[email protected]>
michaelbeaumont pushed a commit that referenced this pull request Aug 2, 2023
@slonka @michaelbeaumont
fix(containerd): only build cgroups on linux (#7408)
5a6d51c 
Signed-off-by: slonka <[email protected]>
michaelbeaumont pushed a commit that referenced this pull request Aug 2, 2023
@slonka @michaelbeaumont
fix(containerd): only build cgroups on linux (#7408)
c55a328 
Signed-off-by: slonka <[email protected]>
michaelbeaumont added a commit that referenced this pull request Aug 2, 2023
@michaelbeaumont
fix(containerd): only build cgroups on linux (#7408)
eafa86e 
Signed-off-by: Mike Beaumont <[email protected]>
michaelbeaumont pushed a commit that referenced this pull request Aug 2, 2023
@kumahq @slonka
fix(containerd): only build cgroups on linux (backport of #7408) (#7422)
24a9c04 
fix(containerd): only build cgroups on linux (#7408)

Signed-off-by: slonka <[email protected]>
Co-authored-by: Krzysztof Słonka <[email protected]>
michaelbeaumont pushed a commit that referenced this pull request Aug 2, 2023
@kumahq @slonka
fix(containerd): only build cgroups on linux (backport of #7408) (#7425)
8b2f7a6 
fix(containerd): only build cgroups on linux (#7408)

Signed-off-by: slonka <[email protected]>
Co-authored-by: Krzysztof Słonka <[email protected]>
michaelbeaumont added a commit that referenced this pull request Aug 2, 2023
@michaelbeaumont
build(formatting): fix indentation from #7408 (#7427)
c3c9d43 
Signed-off-by: Mike Beaumont <[email protected]>
michaelbeaumont pushed a commit that referenced this pull request Aug 2, 2023
@slonka @michaelbeaumont
fix(containerd): only build cgroups on linux (#7408)
5c52fd4 
Signed-off-by: slonka <[email protected]>
michaelbeaumont pushed a commit that referenced this pull request Aug 2, 2023
@slonka @michaelbeaumont
fix(containerd): only build cgroups on linux (#7408)
7549fd6 
Signed-off-by: slonka <[email protected]>
michaelbeaumont pushed a commit that referenced this pull request Aug 2, 2023
@kumahq @slonka
fix(containerd): only build cgroups on linux (backport of #7408) (#7423)
e2af55b 
fix(containerd): only build cgroups on linux (#7408)

Signed-off-by: slonka <[email protected]>
Co-authored-by: Krzysztof Słonka <[email protected]>
michaelbeaumont pushed a commit that referenced this pull request Aug 2, 2023
@kumahq @slonka
fix(containerd): only build cgroups on linux (backport of #7408) (#7426)
c7334f3 
fix(containerd): only build cgroups on linux (#7408)

Signed-off-by: slonka <[email protected]>
Co-authored-by: Krzysztof Słonka <[email protected]>
michaelbeaumont added a commit to michaelbeaumont/kuma that referenced this pull request Aug 3, 2023
@michaelbeaumont
Revert "fix(containerd): only build cgroups on linux (backport of kum…
41aa497 
…ahq#7408) (kumahq#7426)"

This reverts commit c7334f3.
michaelbeaumont added a commit to michaelbeaumont/kuma that referenced this pull request Aug 3, 2023
@michaelbeaumont
Revert "fix(containerd): only build cgroups on linux (backport of kum…
54ce2d1 
…ahq#7408) (kumahq#7423)"

This reverts commit e2af55b.
michaelbeaumont added a commit that referenced this pull request Aug 3, 2023
@michaelbeaumont
Revert "fix(containerd): only build cgroups on linux (backport of #7408…
d9165d8 
…) (#7423)"

This reverts commit e2af55b.

Signed-off-by: Mike Beaumont <[email protected]>
michaelbeaumont added a commit that referenced this pull request Aug 3, 2023
@michaelbeaumont
Revert "fix(containerd): only build cgroups on linux (backport of #7408…
905ae31 
…) (#7422)"

This reverts commit 24a9c04.
michaelbeaumont added a commit that referenced this pull request Aug 3, 2023
@michaelbeaumont
Revert "fix(containerd): only build cgroups on linux (backport of #7408…
db8a261 
…) (#7422)"

This reverts commit 24a9c04.
michaelbeaumont added a commit that referenced this pull request Aug 3, 2023
@michaelbeaumont
build(go.mod): revert containerd changes (#7437)
8e64641 
* Revert "fix(containerd): only build cgroups on linux (backport of #7408) (#7423)"
This reverts commit e2af55b.
* Revert "fix(sec): get rid of dependency on containerd (backport of #7387) (#7389)"
This reverts commit ffae6c2.

Signed-off-by: Mike Beaumont <[email protected]>
michaelbeaumont added a commit that referenced this pull request Aug 3, 2023
@michaelbeaumont
build(go.mod): revert containerd changes (#7436)
78d0f05 
* Revert "fix(containerd): only build cgroups on linux (backport of #7408) (#7426)"
This reverts commit c7334f3.
* Revert "fix(sec): get rid of dependency on containerd (backport of #7387) (#7393)"
This reverts commit ee0e8b7.

Signed-off-by: Mike Beaumont <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

@Automaat Automaat Awaiting requested review from Automaat Automaat is a code owner automatically assigned from kumahq/kuma-maintainers

@bartsmykla bartsmykla Awaiting requested review from bartsmykla bartsmykla is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
backport ci/skip-e2e-test PR: Don't run e2e tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slonka @jakubdyszkiewicz