Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(virtualoutbounds): support multizone #7407

Merged
merged 4 commits into from
Aug 3, 2023
Merged

feat(virtualoutbounds): support multizone #7407

merged 4 commits into from
Aug 3, 2023

Conversation

jakubdyszkiewicz
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz commented Aug 1, 2023 •
edited by lahabana
Loading

Checklist prior to review

Fix #3927

Changelog: feat(VirtualOutbound): support multizone

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@jakubdyszkiewicz jakubdyszkiewicz marked this pull request as ready for review August 1, 2023 13:32
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner August 1, 2023 13:32
@jakubdyszkiewicz jakubdyszkiewicz requested review from Automaat and bartsmykla and removed request for a team August 1, 2023 13:32
lobkovilya
lobkovilya approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@lobkovilya lobkovilya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

michaelbeaumont
michaelbeaumont approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@jakubdyszkiewicz jakubdyszkiewicz enabled auto-merge (squash) August 3, 2023 10:18
@jakubdyszkiewicz jakubdyszkiewicz merged commit 444833e into kumahq:master Aug 3, 2023
@jakubdyszkiewicz jakubdyszkiewicz deleted the feat/multizone-vo branch August 3, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbeaumont michaelbeaumont michaelbeaumont approved these changes

@lobkovilya lobkovilya lobkovilya approved these changes

@Automaat Automaat Awaiting requested review from Automaat Automaat is a code owner automatically assigned from kumahq/kuma-maintainers

@bartsmykla bartsmykla Awaiting requested review from bartsmykla bartsmykla is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make VirtualOutbound work cross Zone
3 participants
@jakubdyszkiewicz @michaelbeaumont @lobkovilya