Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kuma-cp): replace err with log when TargetRef can't be resolved #7032

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

lobkovilya
Copy link
Contributor

@lobkovilya lobkovilya commented Jun 15, 2023

Checklist prior to review

If we return an error when unable to resolve TargetRef (i.e. typo in MeshHTTPRoute name) then:

  • Unable to build DPP config
  • Inspect API returns error

Current PR replaces err with a log. Ideally we need a mechanism like #5870 to process such kind of errors.

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@lobkovilya lobkovilya requested review from a team, michaelbeaumont and lukidzi and removed request for a team June 15, 2023 10:29
@lobkovilya lobkovilya merged commit 9bd8e0e into kumahq:release-2.3 Jun 15, 2023
@lobkovilya lobkovilya deleted the fix/log-if-tr-not-found branch June 15, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants