Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kuma-cp): add possibility to configure kubernetes client qps and… #6951

Merged
merged 5 commits into from
Jun 8, 2023

Conversation

Automaat
Copy link
Contributor

@Automaat Automaat commented Jun 7, 2023

… burst qps

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@Automaat Automaat requested review from a team, slonka and lukidzi and removed request for a team June 7, 2023 10:37
Signed-off-by: Marcin Skalski <[email protected]>
@Automaat
Copy link
Contributor Author

Automaat commented Jun 7, 2023

This pr solves the performance issue with slow creation of new dataplane on k8s with bigger deployments (600+ dpp). On deployment this size we make at most 80 qps, so default of 100 gives some headroom. This should be increased for bigger deployment, I will add docs describing this.
Screenshot 2023-06-07 at 15 42 37

Automaat added 2 commits June 7, 2023 16:18
Signed-off-by: Marcin Skalski <[email protected]>
Signed-off-by: Marcin Skalski <[email protected]>
Signed-off-by: Marcin Skalski <[email protected]>
@lahabana
Copy link
Contributor

lahabana commented Jun 7, 2023

Is there some monitoring we can add to make it obvious when this parameter needs to be bumped?

Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@johnharris85
Copy link
Contributor

LGTM

@Automaat Automaat merged commit 5feabff into kumahq:master Jun 8, 2023
@Automaat Automaat deleted the feat/kube_client_config branch June 8, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants