Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): add mode in the config in the index.html #6942

Merged
merged 1 commit into from
Jun 7, 2023
Merged

feat(ui): add mode in the config in the index.html #6942

merged 1 commit into from
Jun 7, 2023

Conversation

lahabana
Copy link
Contributor

@lahabana lahabana commented Jun 6, 2023

This makes it easier to build the standalone UI differently from the multizone UI

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@lahabana lahabana requested review from kleinfreund, a team, Automaat and lobkovilya and removed request for a team June 6, 2023 15:41
@lahabana
feat(ui): add mode, env and readOnly in the config in the index.html
7766bc5 
This makes it easier to build the standalone UI differently
from the multizone UI

Signed-off-by: Charly Molter <[email protected]>
@lahabana lahabana merged commit 39b8236 into kumahq:master Jun 7, 2023
@lahabana lahabana deleted the indexWithMode branch March 29, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

@bartsmykla bartsmykla bartsmykla approved these changes

@kleinfreund kleinfreund Awaiting requested review from kleinfreund

@Automaat Automaat Awaiting requested review from Automaat

@lobkovilya lobkovilya Awaiting requested review from lobkovilya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lahabana @jakubdyszkiewicz @bartsmykla