Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(policy): ability to skip default policies #6931

Merged
merged 3 commits into from
Jun 9, 2023

Conversation

johnharris85
Copy link
Contributor

@johnharris85 johnharris85 commented Jun 5, 2023

Checklist prior to review

Fixes #3346

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Changelog: feat(mesh): allow disabling default policy creation

@johnharris85 johnharris85 requested review from a team, slonka and jakubdyszkiewicz and removed request for a team June 5, 2023 23:56
@michaelbeaumont michaelbeaumont changed the title feat(Mesh): ability to skip default policies feat(policies): ability to skip default policies Jun 6, 2023
@michaelbeaumont michaelbeaumont changed the title feat(policies): ability to skip default policies feat(policy): ability to skip default policies Jun 6, 2023
@slonka slonka force-pushed the default-policies-impl branch from 8f6f34c to b4b5c14 Compare June 7, 2023 09:18
Copy link
Contributor

@slonka slonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnharris85 made the build step pass, hope you don't mind (you need to run make check before pushing, also if you do mind I won't push to your branches again). Review-wise I agree with Jakub.

Signed-off-by: John Harris <[email protected]>
@johnharris85
Copy link
Contributor Author

All comments addressed :)

@jakubdyszkiewicz jakubdyszkiewicz merged commit f5899d4 into kumahq:master Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

config to disable auto-creating default policies
3 participants