Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(MeshHTTPRoute): rename Prefix to PathPrefix #6578

Merged
merged 5 commits into from
Apr 23, 2023
Merged

fix(MeshHTTPRoute): rename Prefix to PathPrefix #6578

merged 5 commits into from
Apr 23, 2023

Conversation

michaelbeaumont
Copy link
Contributor

Name should match upstream Gateway API

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@michaelbeaumont michaelbeaumont force-pushed the fix/meshhttproute_path_prefix branch from e590911 to 9ca31c5 Compare April 22, 2023 14:13
@michaelbeaumont michaelbeaumont marked this pull request as ready for review April 22, 2023 16:40
@michaelbeaumont michaelbeaumont requested review from a team, Automaat and lukidzi and removed request for a team April 22, 2023 16:40
lukidzi
lukidzi approved these changes Apr 22, 2023
View reviewed changes
Copy link
Contributor

@lukidzi lukidzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add information in the upgrade note that the field has changed?

@michaelbeaumont
docs(UPGRADE.md): add note
3406339 
Signed-off-by: Mike Beaumont <[email protected]>
@michaelbeaumont michaelbeaumont enabled auto-merge (squash) April 23, 2023 15:59
@michaelbeaumont michaelbeaumont merged commit 76c7dc7 into kumahq:master Apr 23, 2023
@michaelbeaumont michaelbeaumont deleted the fix/meshhttproute_path_prefix branch April 23, 2023 16:22
@michaelbeaumont michaelbeaumont mentioned this pull request May 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukidzi lukidzi lukidzi approved these changes

@Automaat Automaat Awaiting requested review from Automaat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelbeaumont @lukidzi