Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kumactl): generate public key command #5917

Merged
merged 1 commit into from
Feb 6, 2023
Merged

feat(kumactl): generate public key command #5917

merged 1 commit into from
Feb 6, 2023

Conversation

jakubdyszkiewicz
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz commented Feb 3, 2023 •
edited
Loading

Add generate public-key command that extracts public key from private key.
Improve generate signing-key with a format so users don't have to convert it by default. Keep base64 by default, we may switch it in the future.

Checklist prior to review

  • Link to docs PR or issue -- not yet. Will do after offline signing functionallity
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests -- no
  • Manual Universal Tests --
  • Manual Kubernetes Tests -- no
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@jakubdyszkiewicz jakubdyszkiewicz marked this pull request as ready for review February 3, 2023 15:41
@jakubdyszkiewicz jakubdyszkiewicz requested review from a team, Automaat and bartsmykla and removed request for a team February 3, 2023 15:41
bartsmykla
bartsmykla approved these changes Feb 6, 2023
View reviewed changes
app/kumactl/cmd/generate/generate_public_key.go
cmd := &cobra.Command{
Use: "public-key",
Short: "Generate public key out of signing key",
Long: `Generate a public key for validating tokens.`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Long: `Generate a public key for validating tokens.`,
Long: "Generate a public key for validating tokens.",

@jakubdyszkiewicz jakubdyszkiewicz merged commit eed566e into kumahq:master Feb 6, 2023
@jakubdyszkiewicz jakubdyszkiewicz deleted the feat/generate-public-key branch February 6, 2023 09:37
@shaneutt shaneutt mentioned this pull request Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartsmykla bartsmykla bartsmykla approved these changes

@Automaat Automaat Awaiting requested review from Automaat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakubdyszkiewicz @bartsmykla