Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 'append' in MeshRateLimit should be 'true' by default #5742

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

lobkovilya
Copy link
Contributor

@lobkovilya lobkovilya commented Jan 17, 2023

In Envoy if Append is not set then it's true by default:

Append
Should the value be appended? If true (default), the value is appended to existing values. Otherwise it replaces any existing values. This field is deprecated and please use append_action as replacement.

We already have this behavior in MeshHealthCheck.

Signed-off-by: Ilya Lobkov [email protected]

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Changelog: feat(policy): implement MeshRateLimit policy

@lobkovilya lobkovilya requested review from a team, michaelbeaumont and slonka and removed request for a team January 17, 2023 18:42
@lahabana lahabana merged commit 4cf748d into kumahq:master Jan 18, 2023
@lobkovilya lobkovilya deleted the fix/append-is-true-by-default branch January 23, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants