Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove superfluous var usage #5627

Merged
merged 1 commit into from
Jan 10, 2023
Merged

fix: remove superfluous var usage #5627

merged 1 commit into from
Jan 10, 2023

Conversation

AyushSenapati
Copy link
Contributor

@AyushSenapati AyushSenapati commented Jan 9, 2023 •
edited by lahabana
Loading

  • Remove unnecessary pkg level var declaration
  • Reset pkg level var, once we are done using it

Signed-off-by: AyushSenapati [email protected]

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Changelog: fix(policy): remove superfluous var usage

@AyushSenapati
fix: remove superfluous var usage
c7fc38f 
- Remove unnecessary pkg level var declaration
- Reset pkg level var, once we are done using it

Signed-off-by: AyushSenapati <[email protected]>
@AyushSenapati AyushSenapati requested review from a team, Automaat and bartsmykla and removed request for a team January 9, 2023 19:52
lobkovilya
lobkovilya approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@lobkovilya lobkovilya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution!

@lobkovilya lobkovilya merged commit 562a162 into kumahq:master Jan 10, 2023
@AyushSenapati AyushSenapati deleted the fix/avoid_superfluous_vars branch January 10, 2023 13:25
bartsmykla pushed a commit to bartsmykla/kuma that referenced this pull request Jan 14, 2023
@AyushSenapati @bartsmykla
fix: remove superfluous var usage (kumahq#5627)
72eb239 
- Remove unnecessary pkg level var declaration
- Reset pkg level var, once we are done using it

Signed-off-by: AyushSenapati <[email protected]>
Signed-off-by: Bart Smykla <[email protected]>
@shaneutt shaneutt mentioned this pull request Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lobkovilya lobkovilya lobkovilya approved these changes

@Automaat Automaat Awaiting requested review from Automaat

@bartsmykla bartsmykla Awaiting requested review from bartsmykla

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AyushSenapati @lobkovilya