Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kuma-cp): fix kafka_type tag creation regex #5507

Merged
merged 3 commits into from
Dec 20, 2022
Merged

fix(kuma-cp): fix kafka_type tag creation regex #5507

merged 3 commits into from
Dec 20, 2022

Conversation

Automaat
Copy link
Contributor

Fixes: #5506
Signed-off-by: Marcin Skalski [email protected]

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@Automaat Automaat requested review from a team, lahabana and lobkovilya and removed request for a team December 14, 2022 15:15
@Automaat
fix(kuma-cp): update golden files
917d6b0 
Fixes: kumahq#5506
Signed-off-by: Marcin Skalski <[email protected]>
@jakubdyszkiewicz jakubdyszkiewicz merged commit a75cc15 into kumahq:master Dec 20, 2022
@shaneutt shaneutt mentioned this pull request Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

@lukidzi lukidzi lukidzi approved these changes

@lahabana lahabana Awaiting requested review from lahabana

@lobkovilya lobkovilya Awaiting requested review from lobkovilya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Metrics hijacker cannot process Kafka stats
3 participants
@Automaat @jakubdyszkiewicz @lukidzi