Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement MeshCircuitBreaker policy plugin #5493

Merged
merged 13 commits into from
Dec 20, 2022
Merged

feat: implement MeshCircuitBreaker policy plugin #5493

merged 13 commits into from
Dec 20, 2022

Conversation

bartsmykla
Copy link
Contributor

@bartsmykla bartsmykla commented Dec 13, 2022 •
edited by lahabana
Loading

Implementation of MeshCircuitBreaker policy plugin

Closes: #5453

Checklist prior to review

  • Link to docs PR or issue -- MeshCircuitBreaker docs kuma-website#1175
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Changelog: feat(policy): implement MeshCircuitBreaker policy

@bartsmykla bartsmykla changed the title feat(*): implement MeshCircuitBreaker policy feat: implement MeshCircuitBreaker policy plugin Dec 13, 2022
@bartsmykla bartsmykla marked this pull request as ready for review December 14, 2022 13:44
@bartsmykla bartsmykla requested review from a team, slonka and jakubdyszkiewicz and removed request for a team December 14, 2022 13:44
@bartsmykla
chore: add e2e test
c95d8bd 
Signed-off-by: Bart Smykla <[email protected]>
@bartsmykla
chore: make check results
632a792 
Signed-off-by: Bart Smykla <[email protected]>
@bartsmykla
chore: remove unused import
85f77b2 
Signed-off-by: Bart Smykla <[email protected]>
jakubdyszkiewicz
jakubdyszkiewicz reviewed Dec 15, 2022
View reviewed changes
@slonka slonka mentioned this pull request Dec 16, 2022
Closed
@slonka slonka requested review from lobkovilya and removed request for slonka December 16, 2022 16:26
@bartsmykla bartsmykla enabled auto-merge (squash) December 19, 2022 08:06
@bartsmykla bartsmykla merged commit 6d42311 into kumahq:master Dec 20, 2022
@shaneutt shaneutt mentioned this pull request Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

@lobkovilya lobkovilya Awaiting requested review from lobkovilya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MeshCircuitBreaker xds plugin implementation
2 participants
@bartsmykla @jakubdyszkiewicz