fix(kuma-cp): disable statsForAllMethods in grpc stats #5226
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It does not make sense to use
statsForAllMethods
at this moment, because it's very common to use dots in grpc package which breaks the StatsD to Prometheus conversion.There is a feature to replace dots with underscores, but Envoy with this feature is not yet released
https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/filters/http/grpc_stats/v3/config.proto#envoy-v3-api-field-extensions-filters-http-grpc-stats-v3-filterconfig-stats-for-all-methods
replace_dots_in_grpc_service_name
.If someone wants to still use it, they can reenable this with ProxyTemplate.
In the future, we can reenable this when Kuma will upgrade to Envoy with
replace_dots_in_grpc_service_name
feature.Changes
statsForAllMethods
Checklist prior to review
syscall.Mkfifo
have equivalent implementation on the other OS --UPGRADE.md
? --> Changelog:
entry here or add aci/
label to run fewer/more tests?