Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(*): remove unused method and types #5148

Merged
merged 2 commits into from
Oct 14, 2022
Merged

chore(*): remove unused method and types #5148

merged 2 commits into from
Oct 14, 2022

Conversation

lobkovilya
Copy link
Contributor

@lobkovilya lobkovilya commented Oct 13, 2022 •
edited by lukidzi
Loading

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? -- No
  • Does it need to be backported according to the backporting policy? -- No
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests? No

Changelog: chore(api): remove unused method and types

@lobkovilya lobkovilya marked this pull request as ready for review October 13, 2022 17:29
@lobkovilya lobkovilya requested a review from a team as a code owner October 13, 2022 17:29
jakubdyszkiewicz
jakubdyszkiewicz approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! I did not like the idea of the sample resource from the beginning. It's good that we are removing it

@lobkovilya lobkovilya merged commit 6aa0eef into kumahq:master Oct 14, 2022
@lobkovilya lobkovilya deleted the chore/cleanup branch October 14, 2022 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

@Automaat Automaat Automaat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lobkovilya @jakubdyszkiewicz @Automaat