Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gateway): match new policies to MeshGateways #5110

Merged
merged 4 commits into from
Oct 7, 2022

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Oct 6, 2022

Really a blocker for #5101 but is worth merging alone since this might break other policy plugins

Note that in particular in the case of MeshGateways, policies match the union of Dataplane tags, MeshGateway tags and MeshGateway listener tags.

> Changelog: skip

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests -- I think this is part of the e2e tests per policy
  • Manual Universal Tests -- none
  • Manual Kubernetes Tests -- none
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@michaelbeaumont michaelbeaumont requested a review from a team as a code owner October 6, 2022 15:04
@lahabana
Copy link
Contributor

lahabana commented Oct 6, 2022

Maybe worth adding a test in the matchers package?

@michaelbeaumont
Copy link
Contributor Author

Yeah it's coming

@michaelbeaumont michaelbeaumont enabled auto-merge (squash) October 7, 2022 09:08
@michaelbeaumont michaelbeaumont merged commit de4d569 into kumahq:master Oct 7, 2022
@michaelbeaumont michaelbeaumont deleted the feat/gateway_match branch October 7, 2022 09:49
@lukidzi lukidzi changed the title feat: match new policies to MeshGateways feat(gateway): match new policies to MeshGateways Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants