-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kuma-cp): universal resources schema validation #5107
feat(kuma-cp): universal resources schema validation #5107
Conversation
Signed-off-by: slonka <[email protected]>
Signed-off-by: slonka <[email protected]>
Signed-off-by: slonka <[email protected]>
Signed-off-by: slonka <[email protected]>
Signed-off-by: slonka <[email protected]>
Signed-off-by: slonka <[email protected]>
Signed-off-by: slonka <[email protected]>
I hit dependency cycle a couple of times while developing this. I have a feeling that our package structure is a bit off. We have validation in multiple places. I'll try to figure out if we can make the structure a bit more straightforward. |
Signed-off-by: slonka <[email protected]>
Signed-off-by: slonka <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Signed-off-by: slonka <[email protected]>
Signed-off-by: slonka <[email protected]>
Signed-off-by: slonka <[email protected]>
Signed-off-by: slonka <[email protected]>
Signed-off-by: slonka <[email protected]>
Signed-off-by: slonka <[email protected]>
Signed-off-by: slonka <[email protected]>
Signed-off-by: slonka <[email protected]>
Signed-off-by: slonka <[email protected]>
Signed-off-by: slonka <[email protected]>
@lobkovilya @jakubdyszkiewicz - because of this being called on all policies I had to manually fix the fixtures. Right now every test case has a passing config. |
Signed-off-by: slonka <[email protected]>
Signed-off-by: slonka <[email protected]>
closes #5037
Checklist prior to review
syscall.Mkfifo
have equivalent implementation on the other OS --UPGRADE.md
? -- no> Changelog:
entry here or add aci/
label to run fewer/more tests? no