Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kuma-cp): universal resources schema validation #5107

Merged
merged 23 commits into from
Oct 13, 2022

Conversation

slonka
Copy link
Contributor

@slonka slonka commented Oct 6, 2022

closes #5037

Checklist prior to review

  • Link to docs PR or issue -- should I mention this here: https://kuma.io/docs/1.8.x/reference/http-api/#http-api?
  • Link to UI issue or PR -- not ui issue
  • Is the issue worked on linked? -- yes
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests -- not a k8s feature
  • Do you need to update UPGRADE.md? -- no
  • Does it need to be backported according to the backporting policy? -- no
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests? no

@slonka slonka marked this pull request as ready for review October 10, 2022 06:40
@slonka slonka requested a review from a team as a code owner October 10, 2022 06:40
@slonka
Copy link
Contributor Author

slonka commented Oct 10, 2022

I hit dependency cycle a couple of times while developing this. I have a feeling that our package structure is a bit off. We have validation in multiple places. I'll try to figure out if we can make the structure a bit more straightforward.

Copy link
Contributor

@lobkovilya lobkovilya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@slonka
Copy link
Contributor Author

slonka commented Oct 12, 2022

@lobkovilya @jakubdyszkiewicz - because of this being called on all policies I had to manually fix the fixtures. Right now every test case has a passing config.

@slonka slonka merged commit 1b3ce91 into kumahq:master Oct 13, 2022
@slonka slonka deleted the feat/universal-resources-validation branch October 13, 2022 10:02
@lukidzi lukidzi changed the title feat(kumacp): universal resources schema validation feat(kuma-cp): universal resources schema validation Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

api should validate against json-schema
3 participants