perf(kuma-cp): avoid rebuilding endpoint map #4974
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes rebuilding endpoint map in
DataplaneProxyBuilder
.We already compute endpoint map for all data plane proxy in the mesh and cache it in
MeshContext
.However, we were rebuilding the map in
DataplaneProxyBuilder
, because if we had no zone egress we decided if we want to include external service endpoints based on traffic permission. I changed the logic to only compute external services endpoint for each data plane proxy and share the endpoint map for the rest of services.This saves a significant amount of CPU (2-3x when benchmarking with in-memory storage and mock Envoys)
Before:


After:

Fix #2989
Checklist prior to review
syscall.Mkfifo
have equivalent implementation on the other OS -- noUPGRADE.md
? -- no> Changelog:
entry here?