-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cni): make cni logs available via kubectl logs #4845
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: slonka <[email protected]>
Signed-off-by: slonka <[email protected]>
Signed-off-by: slonka <[email protected]>
Signed-off-by: slonka <[email protected]>
@Mergifyio backport release-1.8 |
✅ Backports have been created
|
lobkovilya
reviewed
Aug 17, 2022
Signed-off-by: slonka <[email protected]>
lobkovilya
approved these changes
Aug 17, 2022
mergify bot
pushed a commit
that referenced
this pull request
Aug 17, 2022
* fix(cni): make cni logs available via kubectl logs Signed-off-by: slonka <[email protected]> (cherry picked from commit ef89161)
mergify bot
added a commit
that referenced
this pull request
Aug 18, 2022
fix: make cni logs available via kubectl logs (#4845) * fix(cni): make cni logs available via kubectl logs Signed-off-by: slonka <[email protected]> (cherry picked from commit ef89161) Co-authored-by: Krzysztof Słonka <[email protected]>
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: slonka [email protected]
I wrongly assumed that you can't send logs to stdout or stderr. This is not true, logs of "install-cni" can be sent to stderr - kubelet only cares about about stdout. As for "kuma-cni" (the main cni process) to make logs available via "kubectl logs" they need to appear in the daemonset
stderr
so in this PR we hijack this file descriptor and send logs there.Example logs:
As you can see we have logs from both
install-cni
andkuma-cni
Checklist prior to review
syscall.Mkfifo
have equivalent implementation on the other OS -- CNI only works on linux so this is not relevantUPGRADE.md
? --