Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cni): do not hardcode kumahq into image loading procedure #4788

Merged
merged 4 commits into from
Aug 9, 2022

Conversation

slonka
Copy link
Contributor

@slonka slonka commented Aug 9, 2022

Signed-off-by: slonka [email protected]

Checklist prior to review

  • Link to docs PR or issue -- none of these apply only the one with the other comment
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • Unit Tests --
  • E2E Tests -- fixed E2E test in project depending on Kuma
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --

@slonka slonka marked this pull request as ready for review August 9, 2022 12:06
@slonka slonka requested a review from a team as a code owner August 9, 2022 12:06
@slonka slonka marked this pull request as draft August 9, 2022 12:17
@slonka slonka marked this pull request as ready for review August 9, 2022 13:47
@codecov-commenter
Copy link

Codecov Report

Merging #4788 (e48967f) into master (748b719) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4788      +/-   ##
==========================================
- Coverage   46.44%   46.42%   -0.02%     
==========================================
  Files         690      690              
  Lines       47086    47086              
==========================================
- Hits        21868    21860       -8     
- Misses      23292    23299       +7     
- Partials     1926     1927       +1     
Impacted Files Coverage Δ
pkg/plugins/leader/postgres/leader_elector.go 82.97% <0.00%> (-6.39%) ⬇️
pkg/core/resources/manager/cache.go 83.11% <0.00%> (-5.20%) ⬇️
pkg/xds/generator/direct_access_proxy_generator.go 89.77% <0.00%> (-1.14%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@slonka slonka enabled auto-merge (squash) August 9, 2022 14:12
@slonka slonka merged commit e552c96 into master Aug 9, 2022
@slonka slonka deleted the fix/taint-controller-test-depending-projects branch August 9, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants