Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kuma-dp): fix multi OS build of accesslogs #4767

Merged
merged 1 commit into from
Aug 5, 2022
Merged

fix(kuma-dp): fix multi OS build of accesslogs #4767

merged 1 commit into from
Aug 5, 2022

Conversation

lahabana
Copy link
Contributor

@lahabana lahabana commented Aug 4, 2022

Signed-off-by: Charly Molter [email protected]

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --

@lahabana lahabana requested a review from a team as a code owner August 4, 2022 16:39
@lahabana lahabana requested a review from parkanzky August 4, 2022 16:39
@lahabana lahabana mentioned this pull request Aug 4, 2022
Closed
9 tasks
michaelbeaumont
michaelbeaumont approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lahabana lahabana merged commit c4809e1 into kumahq:master Aug 5, 2022
@lahabana lahabana deleted the fixLogOnWindows branch March 29, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbeaumont michaelbeaumont michaelbeaumont approved these changes

@parkanzky parkanzky Awaiting requested review from parkanzky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lahabana @michaelbeaumont