Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gateway): update to Gateway API v0.5.0, support v1beta1 resources #4599

Merged
merged 6 commits into from
Jul 15, 2022

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Jul 14, 2022

Summary

This removes the upstream validator from our webhooks since it's installed as part of the upstream resource bundle. Until we no longer rely on users installing the upstream bundle, I don't think it makes sense to run the webhook ourselves.

Some conformance tests changed and are disabled here until #4597

@michaelbeaumont michaelbeaumont requested a review from a team as a code owner July 14, 2022 12:47
@michaelbeaumont michaelbeaumont changed the title feat(gateway): update to v0.5.0, support v1beta1 resources feat(gateway): update to Gateway API v0.5.0, support v1beta1 resources Jul 14, 2022
This includes referring to v1beta1 where possible.

Signed-off-by: Mike Beaumont <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2022

Codecov Report

Merging #4599 (3dda7bf) into master (ea66f01) will decrease coverage by 0.01%.
The diff coverage is 54.28%.

@@            Coverage Diff             @@
##           master    #4599      +/-   ##
==========================================
- Coverage   46.76%   46.74%   -0.02%     
==========================================
  Files         678      678              
  Lines       45645    45653       +8     
==========================================
- Hits        21344    21340       -4     
- Misses      22432    22442      +10     
- Partials     1869     1871       +2     
Impacted Files Coverage Δ
...8s/controllers/gatewayapi/attachment/attachment.go 69.41% <ø> (ø)
...untime/k8s/controllers/gatewayapi/common/common.go 0.00% <ø> (ø)
...controllers/gatewayapi/gateway_class_controller.go 0.00% <ø> (ø)
...e/k8s/controllers/gatewayapi/gateway_controller.go 0.00% <ø> (ø)
...e/k8s/controllers/gatewayapi/gateway_conversion.go 33.17% <ø> (ø)
...ntime/k8s/controllers/gatewayapi/gateway_status.go 0.00% <ø> (ø)
...8s/controllers/gatewayapi/http_route_controller.go 0.00% <ø> (ø)
...8s/controllers/gatewayapi/http_route_conversion.go 0.00% <ø> (ø)
...me/k8s/controllers/gatewayapi/http_route_status.go 0.00% <ø> (ø)
...ime/k8s/webhooks/gatewayapi_multizone_validator.go 40.90% <50.00%> (+3.40%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea66f01...3dda7bf. Read the comment docs.

@lahabana
Copy link
Contributor

@michaelbeaumont what's the upgrade story here? Is everything just working out of the box and gateway api has all the upgrade webhooks?

@michaelbeaumont
Copy link
Contributor Author

michaelbeaumont commented Jul 15, 2022

It just relies on k8s mechanisms to handle different versions. Resources are always stored as v1alpha2 (this is defined in the upstream CRDs and means there's no storage migration necessary) but can be accessed using either v1alpha2 or v1beta1 APIs. Since they are identical I believe no webhooks are necessary.

@michaelbeaumont michaelbeaumont merged commit a34527e into kumahq:master Jul 15, 2022
@michaelbeaumont michaelbeaumont deleted the build/gapi_0.5.0 branch July 15, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants