-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gateway): update to Gateway API v0.5.0, support v1beta1 resources #4599
feat(gateway): update to Gateway API v0.5.0, support v1beta1 resources #4599
Conversation
This includes referring to v1beta1 where possible. Signed-off-by: Mike Beaumont <[email protected]>
a92cf69
to
30af83c
Compare
Signed-off-by: Mike Beaumont <[email protected]>
Signed-off-by: Mike Beaumont <[email protected]>
It's part of the upstream resources. Signed-off-by: Mike Beaumont <[email protected]>
30af83c
to
8d2f075
Compare
Codecov Report
@@ Coverage Diff @@
## master #4599 +/- ##
==========================================
- Coverage 46.76% 46.74% -0.02%
==========================================
Files 678 678
Lines 45645 45653 +8
==========================================
- Hits 21344 21340 -4
- Misses 22432 22442 +10
- Partials 1869 1871 +2
Continue to review full report at Codecov.
|
Signed-off-by: Mike Beaumont <[email protected]>
8d2f075
to
0c46293
Compare
@michaelbeaumont what's the upgrade story here? Is everything just working out of the box and gateway api has all the upgrade webhooks? |
It just relies on k8s mechanisms to handle different versions. Resources are always stored as |
Signed-off-by: Mike Beaumont <[email protected]>
Summary
This removes the upstream validator from our webhooks since it's installed as part of the upstream resource bundle. Until we no longer rely on users installing the upstream bundle, I don't think it makes sense to run the webhook ourselves.
Some conformance tests changed and are disabled here until #4597