fix(kuma-cp): grant delete Pods in kuma-system namespace to control plane #4571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lane Signed-off-by: Mike Beaumont <[email protected]>
lobkovilya
approved these changes
Jul 8, 2022
|
@lobkovilya @jakubdyszkiewicz @lahabana do we backport this? It's kind of more of a performance/stability fix than anything else |
|
/golden_files |
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
mergify bot
pushed a commit
that referenced
this pull request
Jul 11, 2022
…lane (#4571) * fix(kuma-cp): grant delete Pods in kuma-system namespace to control plane * fix(ci): format files Signed-off-by: Mike Beaumont <[email protected]> Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> (cherry picked from commit b41a35e) # Conflicts: # app/kumactl/cmd/install/testdata/install-control-plane.registry.golden.yaml
mergify bot
added a commit
that referenced
this pull request
Jul 11, 2022
…lane (backport #4571) (#4575) * fix(kuma-cp): grant delete Pods in kuma-system namespace to control plane (#4571) * fix(kuma-cp): grant delete Pods in kuma-system namespace to control plane * fix(ci): format files Signed-off-by: Mike Beaumont <[email protected]> Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> (cherry picked from commit b41a35e) # Conflicts: # app/kumactl/cmd/install/testdata/install-control-plane.registry.golden.yaml * chore: remove unused golden file Signed-off-by: Mike Beaumont <[email protected]> Co-authored-by: Mike Beaumont <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Under certain circumstances
operator-framework/operator-libtries to delete other CP Pods.